Use string ressources, follow some Android best practices

florian staine
1 parent 60729503
Showing 7 changed files with 20 additions and 18 deletions Show diff stats
app/src/main/AndroidManifest.xml
app/src/main/java/fr/utbm/lo53/p2017/positionningapp/AppCompatPreferenceActivity.java
app/src/main/java/fr/utbm/lo53/p2017/positionningapp/PositioningActivity.java
app/src/main/res/layout/content_calibration.xml
app/src/main/res/layout/content_positioning.xml
app/src/main/res/values/colors.xml
app/src/main/res/values/strings.xml
@@ -22,6 +22,7 @@
                 <action android:name="android.intent.action.MAIN" />
  
                 <category android:name="android.intent.category.LAUNCHER" />
+
             </intent-filter>
         </activity>
         <activity
@@ -4,6 +4,7 @@ import android.content.res.Configuration;
 import android.os.Bundle;
 import android.preference.PreferenceActivity;
 import android.support.annotation.LayoutRes;
+import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.v7.app.ActionBar;
 import android.support.v7.app.AppCompatDelegate;
@@ -42,6 +43,7 @@ public abstract class AppCompatPreferenceActivity extends PreferenceActivity {
     }
  
     @Override
+    @NonNull
     public MenuInflater getMenuInflater() {
         return getDelegate().getMenuInflater();
     }
 package fr.utbm.lo53.p2017.positionningapp;
  
-import android.content.Context;
 import android.graphics.Bitmap;
-import android.net.wifi.WifiInfo;
-import android.net.wifi.WifiManager;
-import android.os.Build;
 import android.os.Bundle;
 import android.os.Handler;
 import android.support.constraint.ConstraintLayout;
@@ -18,7 +14,6 @@ import android.view.animation.AccelerateInterpolator;
 import android.view.animation.AlphaAnimation;
 import android.view.animation.Animation;
 import android.view.animation.AnimationUtils;
-import android.view.animation.RotateAnimation;
 import android.widget.ImageView;
  
 import com.android.volley.Request;
@@ -32,10 +27,6 @@ import com.android.volley.toolbox.Volley;
 import org.json.JSONException;
 import org.json.JSONObject;
  
-import java.net.NetworkInterface;
-import java.net.SocketException;
-import java.util.Collections;
-import java.util.List;
 import java.util.Random;
  
 public class PositioningActivity extends BaseActivity {
@@ -183,13 +174,14 @@ public class PositioningActivity extends BaseActivity {
         return (this.mapId != null && this.mapId.equals(mapId));
     }
  
-    private void getMap(int mapId) {
+    private void getMap(final int mapId) {
         mapView.setVisibility(View.INVISIBLE);
         ImageRequest mapRequest = new ImageRequest(
             getURLSolver().mapBytesURL(mapId),
             new Response.Listener<Bitmap>() {
                 @Override
                 public void onResponse(Bitmap bitmap) {
+                    PositioningActivity.this.mapId = mapId;
                     mapView.setImageBitmap(bitmap);
                     mapView.setVisibility(View.VISIBLE);
                     Snackbar.make(mapView, "You need to set a point before measurement.", Snackbar.LENGTH_LONG)
@@ -18,7 +18,7 @@
         android:layout_marginStart="8dp"
         android:layout_marginTop="50dp"
         android:adjustViewBounds="true"
-        android:paddingLeft="0dp"
+        android:paddingStart="0dp"
         android:paddingTop="0dp"
         android:scaleType="fitXY"
         app:layout_constraintHorizontal_bias="0.0"
@@ -52,7 +52,7 @@
         android:layout_marginLeft="8dp"
         android:layout_marginRight="8dp"
         android:layout_marginStart="8dp"
-        android:text="Set Point"
+        android:text="@string/set_point"
         app:layout_constraintHorizontal_bias="0.0"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
@@ -67,7 +67,7 @@
         android:layout_marginLeft="8dp"
         android:layout_marginRight="8dp"
         android:layout_marginStart="8dp"
-        android:text="Cancel"
+        android:text="@string/Cancel"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
         app:layout_constraintHorizontal_bias="0.0"
@@ -83,7 +83,7 @@
         android:layout_marginRight="8dp"
         android:layout_marginStart="8dp"
         android:onClick="sendCalibrateRequest"
-        android:text="Measure"
+        android:text="@string/Measure"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
         app:layout_constraintHorizontal_bias="0.0"
@@ -73,9 +73,10 @@
             android:layout_marginLeft="8dp"
             android:layout_marginRight="8dp"
             android:layout_marginTop="8dp"
-            android:text="Start locating"
-            android:textAppearance="@android:style/TextAppearance.Material.Display2"
+            android:text="@string/start_locating"
+            android:textAppearance="@style/TextAppearance.AppCompat.Large"
             android:textColor="@color/colorAccent"
+            android:textSize="40sp"
             app:layout_constraintBottom_toBottomOf="@+id/hiding_image"
             app:layout_constraintLeft_toLeftOf="parent"
             app:layout_constraintRight_toRightOf="parent"
@@ -2,5 +2,5 @@
 <resources>
     <color name="colorPrimary">#3F51B5</color>
     <color name="colorPrimaryDark">#303F9F</color>
-    <color name="colorAccent">#FF4081</color>
+    <color name="colorAccent">#ff4081</color>
 </resources>
 <resources>
-    <string name="app_name">PositionningApp</string>
+    <string name="app_name">PositioningApp</string>
     <string name="action_settings">Settings</string>
     <string name="title_activity_settings">Settings</string>
  
@@ -91,4 +91,10 @@
  
     <string name="pref_title_port">Port</string>
     <string name="pref_default_port">8080</string>
+
+
+    <string name="set_point">Set point</string>
+    <string name="Cancel">Cancel</string>
+    <string name="Measure">Measure</string>
+    <string name="start_locating">Start locating</string>
 </resources>